-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Vercel and GitHub Private Repo (#62 #39) #98
base: master
Are you sure you want to change the base?
Conversation
backroot
commented
Oct 4, 2020
- Support for Vercel. (https://vercel.com/)
- Support for GitHub private repo.
@backroot is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
d068710
to
b232ee3
Compare
b232ee3
to
006f46c
Compare
@leo Can you check this pull request please? It looks promising |
@kotapeter Thank you for your support ! |
f372476
to
1ca24da
Compare
For what it's worth I tried this branch out and it broke updates for me. |
@ibash |
@@ -6,11 +6,11 @@ module.exports = fileName => { | |||
|
|||
if ( | |||
(fileName.includes('mac') || fileName.includes('darwin')) && | |||
extension === 'zip' | |||
(extension === 'yml') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@backroot curious what this change is for?
@@ -142,6 +146,18 @@ module.exports = ({ cache, config }) => { | |||
return | |||
} | |||
|
|||
if (targetFile) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this change for?
Is this repo abandoned? very frustrating when Electron official docs recommend using it but looks non maintained. |